Re: [Aximx50-port] Re: Detect LCD of Aximx50 and Aximx50(v) series

From: Patrick Steiner <patrick.steiner_at_a1.net>
Date: Wed, 11 Jul 2007 10:36:54 +0200

Paul Sokolovsky wrote:
> Hello Patrick,
>
> Monday, July 9, 2007, 11:04:37 AM, you wrote:
> []
>
>>>>> Why to separate lcd code to own file? We're really on "unite" phase
>>>>> now, with the ultimate aim for as much specific machine's code as
>>>>> possible be in one file. The reason is simple: that's how mainline
>>>>> machines are done, and we'd have troubles spooling 100 files into it
>>>>> instead of 30. So, all currently separate modules are in queue to be
>>>>> merged to main machines definition, so it would be unwise for aximx50
>>>>> to go the opposite direction without real need.
>>>>>
>>>>>
>>>
>>>
>>>> So can you please tell me a device which already uses this method.
>>>>
>>>>
>>> Sure, it's aximx50 ;-).
>>>
>>>
>> i have attached a new patch. now all is in aximx50.c i have also done
>> some code clean up...
>>
>
> Nice, thanks. We actually should come up with standard template for
> machine file - like in which order to define devices, what divider
> comments to use, etc.
>
> So, it's committed, though it violates code style - there should be
> tabs for indentation, not space. Please find time to fix that.
>
changed spaces into tab.
> []
>
>
>

Received on Wed Jul 11 2007 - 04:36:59 EDT

This archive was generated by hypermail 2.2.0 : Fri Jul 20 2007 - 05:47:32 EDT