Re: htcsable support in defconfigman

Hello Michal,

Wednesday, July 4, 2007, 11:51:05 PM, you wrote:

> Hello all

> I would like to present htcsable support in defconfigman. Kernel
> builds with configuration file generated by defconfigman.

> I was unsure of sections:
> -machine.flash
> I tried to be most precise and leave this section unchanged comparing
> to original defconfig, but I am not sure if all options should be
> there. I would appreciate review of it...

  Well, I myself don't do flash, so just leave it as is for now. But
here it clearly lacks specific flash driver...

> -machine.touchscreen
> INPUT_TSDEV ?= $1
> INPUT_TSDEV_SCREEN_X=240
> INPUT_TSDEV_SCREEN_Y=320 - not sure if it is needed or not - I guess I
> will listen to comments on htcapache on that, where I had similar
> doubt.

  No, only EVDEV is needed, and this is handled on kernel subsystem
level. I was just removing such things ;-)

> -machine.keys
> KEYBOARD_ATKBD ?= $1 - I guess this is not necessary, but I left it
> commented, just in case....

  Sure, our devices don't have "AT" keyboard. It's just lazy Linus has
it on by default in standard kernel config...

> I have decided to throw away SPI section as not corresponding to any section....

> As an additional comment - the kernel structure seems to be outdated
> in some parts, ie.
> Intel PXA2xx Implementations section carries
> MACH_HW6900

  Well, that's "normal". Machines get registered under very strange
and funky names, and as the list is not really maintained, it sticks
forever. When we'll have completely nothing else to do, we may
consider just dumping old IDs and re-registering new, consistent ones.

> CONFIG_HTCSABLE_LCD
> HTCSABLE_BACKLIGHT

This is ok, as sable, like h4000, uses ASIC3 GPIOs to control both,
and thus requires shim "child" devices to control initialization
order, as discussed in the other recent message.

> Comments are very welcome.

-- 
Best regards,
 Paul                            mailto:pmiscml_at_gmail.com