Re: [RFC] Generic htc egpio driver

On Sun, Jun 17, 2007 at 05:15:25PM +0200, pHilipp Zabel wrote:
> Hi,
>
> On 6/16/07, Kevin O'Connor <kevin_at_koconnor.net> wrote:
> [...]
> >* Don't require all irq pins to be listed in the "pin info"
> > structure. However, it is now necessary to specify an
> > ".ackRegister" setting in the platform_data struct.
>
> That is good. I have made first tests and so far most things seem to work.
> The attached patch adds bus_shift support so that I don't have to
> pretend that there are 6 additional empty 'registers' between the
> 32-bit aligned actual registers. As bus_shift defaults to 0, no
> changes should be needed for Apache. Ok to commit?

Your patch looks fine to me.

> Next thing I'll need is some simple way to query the IRQ number during
> resume to determine the wakeup IRQ.

I saw this in magician cpld code, but I didn't understand it. Let me
know how you think it is best added to the egpio code.

-Kevin
Received on Sun Jun 17 2007 - 12:21:40 EDT