Re: Navman GPS sleeve patch

On Wed, Jul 19, 2006 at 10:34:54AM +0100, lee nookx wrote:
> Attached is a patch that allows the NavMan GPS sleeve to work with my h3600.
>
> The patch is against the linux-2.4.19-rmk6-pxa1-hh37-4 kernel.

I realize that familiar ships with this version of the kernel. But would
it be possible to get you to develop a patch against hh41.1?

> Let me know if there are any problems, or if you need any further
> information.

No problems. It would be helpful if you dropped any debug statements
that were superflous and explain why you need those DEBUG macros still.

It seems that there are two things to the patch, one is the skip of the
bad UART check and the other is the addition of a parameter to a
function and the use of the data to properly configure a serial struct.

Is it at all possible to get the patch down to these two things. I
especially would like to deal with this comment:
> +
> + // lnookx - Is this needed?
> + state->line = req->line;
> +

Thanks for the patch. Good detective work and simple fixing.

E

-- 
Erik Hovland
mail: erik AT hovland DOT org
web: http://hovland.org/
PGP/GPG public key available on request