Re: [H5400-port] Re: h5400 patch - merge h5400_bt.c back to h5400.c

Hello,

On Sun, 17 Feb 2008 23:51:35 +0100
"Michal Panczyk" <mpanczyk_at_gmail.com> wrote:

[]

> > > There is a reason that bluetooth was on ttyS3. It was because
> > > the other serial lines of the PXA took precedence. Did they
> > > happen to get remapped somewhere? I am willing to accept I am
> > > just out of touch and HWUART has been remapped to BTUART. Or
> > > maybe you have decided to use BTUART in your patch?
>
> > > Hm, I see there's code for both BTUART and HWUART. Is this issue
> > > due to one of (h5400, h5500) being pxa250 and lacking a HWUART?
>
> Honestly - I really don't know much about HWUART and BTUART. h2200.c
> has the same structure and it is based on pxa255....

Yes, h2200-like way is what I meant.

> I am just a user trying to keep the things rolling. Some may say
> changes I provide are "copy&paste", but I really don't feel strong
> enough to modify working code - there must be a reason why it looks
> like that.... I can make some logical (structural) changes, when I am
> sure that it is going work better.
> Probably there is gong to be similar situation withe rest of my
> coming patches.

Well, if you test them on device, that's fine for kernel changes, but
not exactly fine for example for OE change /dev/ttyS3 -> /dev/ttyS1.
There should be reason why ttyS3 was used, and should be reason why
to change it to S1. For example, Erik's last mail gives good picture of
how it is, that should be copied into ticker description when
submitting OE patch. But it's still worth trying to do testing
to confirm that and consider how to account for that. I understand that
you might not have much time for that, but you at least work on that
area, so if you won't have it cleaned up, it will pass long time before
someone else will hit it again.

So, the picture is: if you have h5400 (forgive me, I don't remember
this), you should have only /dev/ttyS1. S3 simply shouldn't exist,
that's why it cannot be used for BT. For h5100/h5500, both devices
should exist, and both should be usable with hciattach. The question -
is going off simple way and using /dev/ttyS3 on those devices is really
beneficial vs the need to bother to distinguish h5400 vs h5100/h5500?

I personally don't have clear picture how HWUART is better BTUART.
IIRC, HWUART allows for higher speed range, but even BTUART should be
able to do 900K. So, finding 10mins to read PXA manual may be
beneficial here (and the whole matter of figuring this out should be big
fun ;-) ).

>
>
> Cheers
> Michal Panczyk

-- 
Best regards,
 Paul                          mailto:pmiscml_at_gmail.com