Re: [H5400-port] Re: h5400 patch - merge h5400_bt.c back to h5400.c

On Thu, Feb 14, 2008 at 11:57:38PM +0100, Michal Panczyk wrote:
> Hi Erik !
> I plan to submit patches - including removal of IPAQ_H5400_BT - once I
> know it got accepted.

I guess I should counter that to help get your patch accepted it should:
- Root itself at head of the tree. That means that it should be a diff
  that starts at kernel26 and not linux/kernel26. That way a simple
  'patch -p1 < your-change.patch' works.
- The patch focuses on doing the one thing you set out to do. It can be
  broken into two patches, but they should be attached to the same
  email.

We are a lazy bunch and prefer to have you do all of the lifting. It
will get your patch accepted faster.

> Another thing - I think before accepting this patch it would be nice
> to resolve the led problem, but I am not too familiar with led
> triggers...

Agreed. But it probably didn't work previously. So as long as bluetooth
works, it is fine with me.

> I am going to take care of the problem in complex way - fix the
> kernel, notify bugzilla, and fix the problem in oe. Other planed
> patches are :
> defconfigman - the kernel configuration
> blueprobe in oe.dev - patch for ttyS1 instead of ttyS3

There is a reason that bluetooth was on ttyS3. It was because the other
serial lines of the PXA took precedence. Did they happen to get
remapped somewhere? I am willing to accept I am just out of touch and
HWUART has been remapped to BTUART. Or maybe you have decided to use
BTUART in your patch?

E

-- 
Erik Hovland
mail: erik_at_hovland.org
web: http://hovland.org/
PGP/GPG public key available on request