Re: Patch adding support for FSC Loox N560

Dne Thursday 13 of December 2007 19:25:24 jste napsal(a):
> On Dec 13, 2007 7:32 AM, Marek Vašut <marek.vasut_at_gmail.com> wrote:
> > Dne Thursday 13 of December 2007 01:58:13 jste napsal(a):
> > > Hello Marek,
> > >
> > > Thursday, December 13, 2007, 2:15:25 AM, you wrote:
> > > > Ok, sure, I will clean it up. Thanks for the suggestions. I will try
> > > > to send fixed patch soon (hopefully tomorow). As for the differences,
> > > > N560 and C550 differ only in GPS module (560 has it, 550 doesnt) and
> > > > cpu speed so they really can be put together. Any suggestions for
> > > > unified name ?
> > >
> > > Unified name, no. But there's no need to have duplicated source code
> > > for two of them in this case. Just add machine record to the existing
> > > code, and where needed, is_machine_XXX() checks, voila. Well, back to
> > > name, using name of just one device is quick solution (i.e. c550/ or
> > > c550.c hosts both).
> >
> > Which can be pretty confusing though (in my opinion that is) ... but
> > whatever, I will incorporate it into c550 then.
>
> I agree. Can't you rename the c550.c into loox.c then?

Nope, there are other looxes that have too different hardware unfortunatelly.

> I completely agree with everything Anton said,
> only for decoration (alignment of "=" symbols) I suggest to use spaces.
> Let's keep tabs for indentation, as their width can change from editor to
> editor.
>
> regards
> Philipp

I included new patch. This one fixes stuff in looxc550, merges files and adds
N560 there.