Re: Patch adding support for FSC Loox N560

Hello Marek,

Thursday, December 13, 2007, 2:15:25 AM, you wrote:

> Ok, sure, I will clean it up. Thanks for the suggestions. I will try to send
> fixed patch soon (hopefully tomorow). As for the differences, N560 and C550
> differ only in GPS module (560 has it, 550 doesnt) and cpu speed so they
> really can be put together. Any suggestions for unified name ?

Unified name, no. But there's no need to have duplicated source code
for two of them in this case. Just add machine record to the existing
code, and where needed, is_machine_XXX() checks, voila. Well, back to
name, using name of just one device is quick solution (i.e. c550/ or
c550.c hosts both).

> Dne Thursday 13 of December 2007 01:10:22 jste napsal(a):
>> Hello Anton,
>>
>> Thursday, December 13, 2007, 1:46:15 AM, you wrote:
>> > On Wed, Dec 12, 2007 at 10:18:41PM +0100, Marek Vašut wrote:
>> >> Hi,
>> >
>> > Hi!
>> >
>> >> this patch adds support for FSC Loox N560 handheld. So far kernel boots
>> >> and can read rootfs from memory card. Patch is mostly based on C550 port
>> >> with some minor cleanups.
>>
>> []
>>
>> > p.s. Who is gonna to commit this? And where to? ;-) Paul seem to
>> > busy nowadays.
>>
>> I can commit this, of course. Especially once I'll be sure that
>> differences comparing to c550 are worth forking a new machine ;-).

> _______________________________________________
> Kernel-bugs mailing list
> Kernel-bugs_at_handhelds.org
> https://www.handhelds.org/mailman/listinfo/kernel-bugs

-- 
Best regards,
 Paul                            mailto:pmiscml_at_gmail.com