Re: [PATCH] save/restore samcop gpio configuration upon PM events

From: Milan Plzik <milan.plzik_at_gmail.com>
Date: Sun, 30 Sep 2007 21:12:27 +0200

On So, 2007-09-29 at 23:32 +0300, Paul Sokolovsky wrote:
> Hello Milan,

  Hello:)

>
> Wednesday, September 26, 2007, 9:17:50 PM, you wrote:
>
> > New revision of patch, with static functions and added some
> > whitespace:)
>
> This patch has broken whitespace. Please attach files, don't paste
> them inline. Please resubmit, now apparently against the previous
> version, which was committed. Thanks.

  I apologize, and also hope this is the last resubmit for this patch.
Once again sorry, so far I'll stop experimenting and send the patch as
normal attachment:)

        Milan

whitespace and 'static' fixes

From: Milan Plzik <milan.plzik_at_gmail.com>

---
 drivers/mfd/samcop_base.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/samcop_base.c b/drivers/mfd/samcop_base.c
index eb8f9f2..656c175 100644
--- a/drivers/mfd/samcop_base.c
+++ b/drivers/mfd/samcop_base.c
@@ -984,28 +984,28 @@ void samcop_set_gpio_int_enable(struct device *dev, unsigned int idx, u32 mask,
 	spin_unlock_irqrestore(&samcop->gpio_lock, flags);
 }
 
-void samcop_gpio_suspend(struct platform_device *pdev)
+static void samcop_gpio_suspend(struct platform_device *pdev)
 {
 	struct samcop_data *samcop;
 	int i;
 
 	samcop = platform_get_drvdata(pdev);
 
-	for (i=0; i<SAMCOP_GPIO_REGISTERS; i++) {
+	for (i = 0; i < SAMCOP_GPIO_REGISTERS; i++) {
 		samcop->gpio_suspend_data[i] = 
-			samcop_read_register(samcop, _SAMCOP_GPIO_Base + i*4);
+			samcop_read_register(samcop, _SAMCOP_GPIO_Base + i * 4);
 	};
 }
 
-void samcop_gpio_resume(struct platform_device *pdev)
+static void samcop_gpio_resume(struct platform_device *pdev)
 {
 	struct samcop_data *samcop;
 	int i;
 
 	samcop = platform_get_drvdata(pdev);
 
-	for (i = 0; i< SAMCOP_GPIO_REGISTERS; i++) {
-		samcop_write_register(samcop, _SAMCOP_GPIO_Base + i*4, 
+	for (i = 0; i < SAMCOP_GPIO_REGISTERS; i++) {
+		samcop_write_register(samcop, _SAMCOP_GPIO_Base + i * 4, 
 			samcop->gpio_suspend_data[i]);
 	};
 }
Received on Sun Sep 30 2007 - 15:12:27 EDT

This archive was generated by hypermail 2.2.0 : Sun Sep 30 2007 - 15:13:22 EDT