Re: [RFC] Preliminary hackndev.com Linux kernel patchset for merging to handhelds.org kernel26 tree

On Thu, Sep 20, 2007 at 02:05:40PM +0400, Sergey Lapin wrote:
> Hi, all!

Hi Sergey,

> Patchset is located at this URL:
> http://ossfans.org/patchsets/patchset-20070918

Few comments on patches (though I didn't look them all):

1. None patch contains description. E.g. I'm uncertain what that patch
   for: drivers-mtd-mtdcore.c.diff.

2. Touchscreens. I see some touchscreen drivers contains ADC and battery
   stuff. We have ADC subsystem (drivers/misc/adc/) and shiny ADC
   touchscreen driver (drivers/input/touchscreen/ts-adc.c), and power
   supply subsystem. This should simplify code a lot.

3. Flash map drivers. They all seem to use physically mapped CFI.
   You can use mainline's physmap_flash.c driver, see
   arch/arm/mach-pxa/h5400/h5400.c as an example of use.

4. drivers-misc-battchargemon.c.diff ?? Please use drivers/power/,
   this stuff already in the mainline.

5. arch-arm-mach-pxa-palmtt5.diff adds
   arch/arm/mach-pxa/palmtt5/palmtt5_battery.c driver. Drivers should
   go into the drivers/. That particular driver to the drivers/power/.

   Probably there is more such misplaced drivers.

6. arch-arm-mach-pxa-pxa27x.c.diff looks scary, can CKEN changes harm
   existing machines? I guess so. #ifdef with a comment needed.

7. arch-arm-mm.diff needs a huge description, possibly RFC to lakml.
   And definitely it needs #ifdef.

8. Do I remember correctly that someday we agreed to not write new code
   that contradicts mainline CodingStyle?.. If so, I suggest fixing it.
   This will ease mainline submission in future (if you're planning).
   That isn't a blocker, though. Whole hh.o tree affected anyway.
   Up to date linux/scripts/checkpatch.pl is a nice tool, btw.

> Thanks a lot,
> S.

Thank you,

-- 
Anton Vorontsov
email: cbou_at_mail.ru
backup email: ya-cbou_at_yandex.ru
irc://irc.freenode.net/bd2