Re: [patch] Fix gpiodev bugs

From: pHilipp Zabel <philipp.zabel_at_gmail.com>
Date: Mon, 3 Sep 2007 20:10:31 +0200

On 9/3/07, Kevin O'Connor <kevin_at_koconnor.net> wrote:
> Hi,
>
> In working with the gpiodev2 infrastructure, I came across a couple of
> omissions. When using the gpio_XXX() functions on gpios registered
> via gpiodev2, some of the wrappers cause unexpected behavior. FWIW, I
> spent several hours tracking these down.

Heh, terrific. I'll apply that, only with pxa_gpio_set_value using
else instead of
return, ok?

@@ -252,8 +267,10 @@
 {
         if (gpio < GPIO_BASE_INCREMENT)
                 __gpio_set_value(gpio, value);
+ else
+ gpiodev2_set_value(gpio, value);
- gpiodev2_set_value(gpio, value);
 }

cheers
Philipp
Received on Mon Sep 03 2007 - 14:11:21 EDT

This archive was generated by hypermail 2.2.0 : Mon Sep 03 2007 - 14:11:39 EDT