Re: [PATCH] H5000 PCMCIA timing fix

On Po, 2007-08-27 at 14:28 +0300, Paul Sokolovsky wrote:
> Hello Milan,
>
> Friday, August 3, 2007, 10:19:26 PM, you wrote:
>
> > Hello,
>
> > attached patch modifies a bit drivers/pcmcia/pxa2xx_base.c 's timing
> > calculation routines, adding +2 to originally calculated value for
> > assertion time. As a result, e.g. orinoco gold wireless card works
> > correctly.
>
> > This modification was found only by experimenting, I'm not sure
> > whether it is suitable or even sane for other devices than H5400.
> > Therefore it's #ifdef'ed for H5400 only.
>
> > Sleeve was so far tested with the orinoco card, one pcnet_cs
> > compatible card, both seemed to work more or less fine (orinoco card had
> > to be reset once or twice when running ipkg upgrade, but no harm to the
> > system, except for higher latency during reset period).
>
> Committed, thanks! But as Anton points out, that's just a workaround
> - probability that h5000 has some adhoc PCMCIA requirements is small.
> It would be nice to reduce that to single formula.

  Yes, the main problem is that there are some local modifications in
that file inside handhelds.org CVS, when compared to vanilla kernel. I
would like to discuss this with people who made the change, because I
don't know what I could break if I just re-wrote it. I hope making the
assert time a bit longer doesn't break other ports... .

>
> > Milan
>
>

        Milan
Received on Mon Aug 27 2007 - 13:48:13 EDT