Re: [PATCH] H5000 PCMCIA timing fix

Hello Milan,

Friday, August 3, 2007, 10:19:26 PM, you wrote:

> Hello,

> attached patch modifies a bit drivers/pcmcia/pxa2xx_base.c 's timing
> calculation routines, adding +2 to originally calculated value for
> assertion time. As a result, e.g. orinoco gold wireless card works
> correctly.

> This modification was found only by experimenting, I'm not sure
> whether it is suitable or even sane for other devices than H5400.
> Therefore it's #ifdef'ed for H5400 only.

> Sleeve was so far tested with the orinoco card, one pcnet_cs
> compatible card, both seemed to work more or less fine (orinoco card had
> to be reset once or twice when running ipkg upgrade, but no harm to the
> system, except for higher latency during reset period).

  Committed, thanks! But as Anton points out, that's just a workaround
- probability that h5000 has some adhoc PCMCIA requirements is small.
It would be nice to reduce that to single formula.

> Milan

-- 
Best regards,
 Paul                            mailto:pmiscml_at_gmail.com