Re: [iPAQ] Alsa & 2.4.19-pxa2-hh11 ?

From: Michael Nidd <mni.a.t.zurich.ibm.com>
Date: Wed Feb 26 2003 - 12:56:42 EST

In compiling the alsa-lib stuff, I came across a problem with iatomic.h
It seems to have half-way switched from asm/system.h to asm/proc/system.h

That is to say that its include is for asm/proc/system.h, but it uses
__save_flags_cli and __restore_flags that are defined in asm/system.h

I've seen some people saying that some Linux ports have removed the #ifdef
__KERNEL__ from their linux/kernel/include/asm-arm/{atomic.h,system.h} files,
but that's a seperate point, since the one for Familiar just does this:
#define __save_flags_cli(x) local_irq_save(x)
#define __save_flags(x) local_save_flags(x)
#define __restore_flags(x) local_irq_restore(x)

So, I did a search and replace on asm-lib/include/iatomic.h to change all the
kernel-type calls to the local_ versions from asm/proc.

This leads to two questions:
1) Did I just do something really stupid?
2) Why did it compile for other people?

-----------------------------------------------------------------------
Michael Nidd
IBM Zurich Research Laboratory
Saumerstrasse 4
CH-8803 Rueschlikon/Switzerland
mni@zurich.ibm.com Tel: +41-1-724-89-30 Fax: +41-1-724-89-53

  If you tell the truth, you don't have to remember anything.
Received on Wed Feb 26 17:57:16 2003

This archive was generated by hypermail 2.1.8 : Tue May 04 2004 - 09:45:01 EDT