RE: [iPAQ] patch for IrDA for the iPAQ

Thank you Jan.

Patch applied.

Best Regards,

--George

George France, france@crl.dec.com
Cambridge Research Laboratory, Compaq Computer Corporation
One Cambridgecenter MS: CRL
Cambridge, MA 02142 USA

> -----Original Message-----
> From: Jan Harkes [mailto:jaharkes@cs.cmu.edu]
> Sent: Thursday, September 28, 2000 2:43 PM
> To: Rajesh Krishna Balan
> Cc: ipaq@handhelds.org
> Subject: Re: [iPAQ] patch for IrDA for the iPAQ
>
>
> On Thu, Sep 28, 2000 at 01:51:01PM -0400, Rajesh Krishna Balan wrote:
> > Hi,
> >
> > the logic for turning on the IR hardware on the iPAQ seems
> to have been
> > inverted in serial_sa1100.c in drivers/char
> >
> > attached is a patch which solves the problem for me and
> turns on the IR
> > harcware.
> >
> > Rajesh
>
> Almost, you forgot the third place where the bit it twiddled, when the
> serial ports are initialized after booting. This might actually reduce
> some of the hidden power drain during the suspend.
>
> There are no powermanagement hooks in this driver, so kill irattach
> before suspending if you really want to see the difference.
>
> IrDA in SIR mode works fine after this patch. irlan is broken, but
> that one seems to be broken on i386 as well, the second machine that
> joins the LAN dies horribly. I first crashed the iPAQ, and on
> the second
> try managed to crash my laptop.
>
> Jan
>
> --8<-----------------------------------------------------------------
> --- kernel/drivers/char/serial_sa1100.c.orig Thu Sep 28 14:30:16 2000
> +++ kernel/drivers/char/serial_sa1100.c Thu Sep 28 14:30:55 2000
> @@ -589,7 +589,7 @@
>
> #ifdef CONFIG_SA1100_BITSY
> if (machine_is_bitsy()) {
> - clr_bitsy_egpio(EGPIO_BITSY_IR_ON);
> + set_bitsy_egpio(EGPIO_BITSY_IR_ON);
> }
> #endif
>
> @@ -654,7 +654,7 @@
>
> #ifdef CONFIG_SA1100_BITSY
> if (machine_is_bitsy()) {
> - set_bitsy_egpio(EGPIO_BITSY_IR_ON);
> + clr_bitsy_egpio(EGPIO_BITSY_IR_ON);
> }
> #endif
> }
> @@ -1908,7 +1908,7 @@
> #endif
> #ifdef CONFIG_SA1100_BITSY
> if( machine_is_bitsy() ) {
> - set_bitsy_egpio(EGPIO_BITSY_IR_ON);
> + clr_bitsy_egpio(EGPIO_BITSY_IR_ON);
> Ser2UTCR4 = UTCR4_HSE;
> Ser2HSCR0 = 0;
> Ser2HSSR0 = HSSR0_EIF | HSSR0_TUR |
> HSSR0_RAB | HSSR0_FRE;
> _______________________________________________
> iPAQ mailing list
> iPAQ@handhelds.org
> http://handhelds.org/mailman/listinfo/ipaq
>
Received on Thu Sep 28 13:21:40 2000