Re: hx4700 fb mode 640x480

Hello Roman,

Tuesday, November 13, 2007, 5:21:35 PM, you wrote:

> Hi, it is fix for fb 640x480 mode, it allow to use Ximageon with screen
> rotation on hx4700 (needed some changes in Ximageon for screen and
> touchscreen coordination). There are some trouble with screen corruption
> while suspend/resume with screen orientation 90 or 270.

  What's background of this specific patch? What exactly "some
trouble" means? What issues this patch itself will bring? What about
320x240 mode?

  I suggest opening a bug in bugtracker with detailed description of
the issue and why it is fixed this way, so possible future regressions
can be tracked properly.
  

> diff -urN kernel26/arch/arm/mach-pxa/hx4700/hx4700_lcd.c
> kernel26.new/arch/arm/mach-pxa/hx4700/hx4700_lcd.c

> --- kernel26/arch/arm/mach-pxa/hx4700/hx4700_lcd.c 2007-05-07 14:18:
> 36.000000000 +0400
> +++ kernel26.new/arch/arm/mach-pxa/hx4700/hx4700_lcd.c 2007-11-13 15:34:
> 48.000000000 +0300
> @@ -175,7 +175,7 @@
> .crtc_goe = 0,
> .pll_freq = 95,
> .pixclk_divider = 4,
> - .pixclk_divider_rotated = 4,
> + .pixclk_divider_rotated = 9,
> .pixclk_src = CLK_SRC_PLL,
> .sysclk_divider = 0,
> .sysclk_src = CLK_SRC_PLL,

-- 
Best regards,
 Paul                            mailto:pmiscml_at_gmail.com