Re: [PATCH] arm/pxa25x: HP iPAQ h5000

On Tue, Sep 16, 2008 at 04:45:38PM +0200, Milan Plzik wrote:
> +static struct physmap_flash_data h5000_flash_data[] = {
> + {
> + .width = 4,
> + .parts = h5000_flash0_partitions,
> + .nr_parts = ARRAY_SIZE(h5000_flash0_partitions),
> + },
> + {
> + .width = 4,
> + .parts = h5000_flash1_partitions,
> + .nr_parts = ARRAY_SIZE(h5000_flash1_partitions),
> + },
> +};

Just declare this as two separate data structures for each flash
device.

> +
> +static struct resource h5000_flash_resources[] = {
> + {
> + .start = PXA_CS0_PHYS,
> + .end = PXA_CS0_PHYS + SZ_32M - 1,
> + .flags = IORESOURCE_MEM | IORESOURCE_MEM_32BIT,
> + },
> + {
> + .start = PXA_CS0_PHYS + SZ_32M,
> + .end = PXA_CS0_PHYS + SZ_32M + SZ_16M - 1,
> + .flags = IORESOURCE_MEM | IORESOURCE_MEM_32BIT,
> + },
> +};

Ditto.

> + GPIO_NR_H5000_OPT_SPI_CS_N | MFP_DIR_OUT,
> +
> + /* H5000 GPIO */
> + GPIO_NR_H5000_POWER_BUTTON | MFP_DIR_IN,
> + GPIO_NR_H5000_RESET_BUTTON_N | MFP_DIR_IN,
> + GPIO_NR_H5000_OPT_INT | MFP_DIR_IN,
> + GPIO_NR_H5000_BACKUP_POWER | MFP_DIR_IN, /* XXX should be an output? */
> + GPIO_NR_H5000_ACTION_BUTTON | MFP_DIR_IN,
> + GPIO_NR_H5000_COM_DCD_SOMETHING | MFP_DIR_IN,
> + GPIO_NR_H5000_RESET_BUTTON_AGAIN_N | MFP_DIR_IN,
> + GPIO_NR_H5000_RSO_N | MFP_DIR_IN, /* BATT_FAULT */
> + GPIO_NR_H5000_ASIC_INT_N | MFP_DIR_IN,
> + GPIO_NR_H5000_BT_ENV_0 | MFP_DIR_OUT,
> + GPIO_NR_H5000_BT_ENV_1 | MFP_DIR_OUT,
> + GPIO_NR_H5000_BT_WU | MFP_DIR_IN,
> + GPIO_NR_H5000_IRDA_SD | MFP_DIR_OUT,
> + GPIO_NR_H5000_POWER_SD_N | MFP_DIR_OUT, /* XXX not really active low? */
> + GPIO_NR_H5000_POWER_RS232_N | MFP_DIR_OUT | MFP_LPM_DRIVE_HIGH,
> + GPIO_NR_H5000_POWER_ACCEL_N | MFP_DIR_OUT | MFP_LPM_DRIVE_HIGH,
> + GPIO_NR_H5000_OPT_NVRAM | MFP_DIR_OUT,
> + GPIO_NR_H5000_CHG_EN | MFP_DIR_OUT,
> + GPIO_NR_H5000_USB_PULLUP | MFP_DIR_OUT,
> + GPIO_NR_H5000_BT_2V8_N | MFP_DIR_OUT | MFP_LPM_DRIVE_HIGH,
> + GPIO_NR_H5000_EXT_CHG_RATE | MFP_DIR_OUT,
> + GPIO_NR_H5000_CIR_RESET | MFP_DIR_OUT,
> + GPIO_NR_H5000_POWER_LIGHT_SENSOR_N | MFP_DIR_OUT | MFP_LPM_DRIVE_HIGH,
> + GPIO_NR_H5000_BT_M_RESET | MFP_DIR_OUT,
> + GPIO_NR_H5000_STD_CHG_RATE | MFP_DIR_OUT,
> + GPIO_NR_H5000_SD_WP_N | MFP_DIR_IN, /* XXX docs say output */
> + GPIO_NR_H5000_MOTOR_ON_N | MFP_DIR_OUT | MFP_LPM_DRIVE_HIGH,
> + GPIO_NR_H5000_HEADPHONE_DETECT | MFP_DIR_IN,
> + GPIO_NR_H5000_USB_CHG_RATE | MFP_DIR_OUT,
> +
> + /* N/C */
> + 6 | MFP_DIR_IN,
> + 8 | MFP_DIR_OUT,
> + 16 | MFP_DIR_OUT,
> + 17 | MFP_DIR_OUT,
> + 22 | MFP_DIR_OUT,
> + 27 | MFP_DIR_OUT,
> + 59 | MFP_DIR_OUT, /* XXX docs say "usb charge on" input */
> + 63 | MFP_DIR_OUT,
> + 69 | MFP_DIR_OUT,

I think comments have already been passed on these, and the rest of the
patch.
Received on Mon Sep 29 2008 - 11:12:56 EDT