Re: Re: [Kernel-bugs] h5400 patch - merge h5400_bt.c back to h5400.c

On Sun, Feb 17, 2008 at 11:51:35PM +0100, Michal Panczyk wrote:
> > > Hm, I see there's code for both BTUART and HWUART. Is this issue due to
> > > one of (h5400, h5500) being pxa250 and lacking a HWUART?
>
> Honestly - I really don't know much about HWUART and BTUART. h2200.c
> has the same structure and it is based on pxa255....
> I am just a user trying to keep the things rolling. Some may say
> changes I provide are "copy&paste", but I really don't feel strong
> enough to modify working code - there must be a reason why it looks
> like that.... I can make some logical (structural) changes, when I am
> sure that it is going work better.
> Probably there is gong to be similar situation withe rest of my coming patches.

Here is the thing. On the h54xx, the pxa-250 is used. It only has the
BTUART. The h51xx and the 55xx both use the pxa-255 and therefore have
the HWUART as well on exactly the same pins. I haven't looked at the
current code very closely. But this difference should be accounted for.
The h54xx folk can only use BTUART for bluetooth usage and h55xx folk
could really use the hardware flow control to improve bluetooth
performance.

I am pretty sure that this is taken care of in the pxa code. So I don't
think you have to worry about it. But it might make a difference in your
patch.

E

-- 
Erik Hovland
mail: erik_at_hovland.org
web: http://hovland.org/
PGP/GPG public key available on request