Sorry for being laconic - it was the middle of the night for me.....
> > I guess I should counter that to help get your patch accepted it should:
> > - Root itself at head of the tree. That means that it should be a diff
> > that starts at kernel26 and not linux/kernel26. That way a simple
> > 'patch -p1 < your-change.patch' works.
That is done it the submitted patch.
> > - The patch focuses on doing the one thing you set out to do. It can be
> > broken into two patches, but they should be attached to the same
> > email.
Also done.
> > We are a lazy bunch and prefer to have you do all of the lifting. It
> > will get your patch accepted faster.
Ok. Once this is accepted I will finish the job of non-kernel related patches.
> > There is a reason that bluetooth was on ttyS3. It was because the other
> > serial lines of the PXA took precedence. Did they happen to get
> > remapped somewhere? I am willing to accept I am just out of touch and
> > HWUART has been remapped to BTUART. Or maybe you have decided to use
> > BTUART in your patch?
> > Hm, I see there's code for both BTUART and HWUART. Is this issue due to
> > one of (h5400, h5500) being pxa250 and lacking a HWUART?
Honestly - I really don't know much about HWUART and BTUART. h2200.c
has the same structure and it is based on pxa255....
I am just a user trying to keep the things rolling. Some may say
changes I provide are "copy&paste", but I really don't feel strong
enough to modify working code - there must be a reason why it looks
like that.... I can make some logical (structural) changes, when I am
sure that it is going work better.
Probably there is gong to be similar situation withe rest of my coming patches.
Cheers
Michal Panczyk
Received on Sun Feb 17 2008 - 17:51:40 EST
This archive was generated by hypermail 2.2.0 : Sun Feb 17 2008 - 17:52:32 EST