Re: [Kernel-bugs] h5400 patch - merge h5400_bt.c back to h5400.c

Hello,

On Thu, 14 Feb 2008 02:08:11 +0100
"Michal Panczyk" <mpanczyk_at_gmail.com> wrote:

> Hello all!
> After some work and testing I propose a patch bringing back the
> bluetooth support back to main file of h5400.

Nice work!

>
> I have tested this on h5455 device (not h55xx series), but I think it
> was so trivial that it shouldn't brake on other devices.
>
> Known issues :
> *bluetooth shows up on /dev/ttyS1:
> so blueproble has to be modified (I will porpose a patch on angstrom
> bugzilla for that)

Hm, I see there's code for both BTUART and HWUART. Is this issue due to
one of (h5400, h5500) being pxa250 and lacking a HWUART?

> a sample command to get the bluetooth working is '/sbin/hciattach
> /dev/ttyS1 any 921600'
> I am not sure if blueprobe works ok, even after patches... - it would
> be nice if somebody could have a look on that.
> *hci_uart module needs to be loaded - otherwise BT won't work
> it would be nice to make it automatic (I don't know how to do it )
> *blue led flashes continuously - it doesn't blink (it worked the same
> before the merge)

LEDs are just LEDs, not BT ;-).

> I would ask for some help here too...
> *I am not sure if we really need the include/asm-arm/arch-pxa/h5400.h
> file... there is hardly anything there....

Yes, each machine should (ideally) consist of 2 files: <machine>.h and
<machine>.c. So,h5400-{asic,gpio,init}.h all should be merged to h5000.h

>
> Otherwise it works ok - even after suspend....
>
> If there is someone lazy who would like to verify my work and does not
> like playing with patching kernel and building images he is a link
> that a test console image is available:
> http://delta-9-thc.czuby.net/~yans/hh/h5000/
>
> My next steps:
> Once patch gets accepted, I will submit patches to OE (angstrom),
> propose patch marking H5400_BT as obsolete (or maybe it is better to
> remove that? )

Continuing Erik's idea and what's written above, it would be nice to
have patches addressing one issue, but "complete". So, if you merge one
file to another, then patch better include removal of the file no
longer needed and config symbols it defines. On the other hand, LED
triggers are pretty separate matter, so can wait for another patch
(which should consider the fact that there're many devices with a BT
LED, I would add).

> and continue with rest (harder part) of the stuff -
> LCD, BL and maybe wifi ....
>
> I would be grateful for comments, testing and some help with issues I
> marked.....
>
>
> Cheers
> Michal Panczyk

-- 
Best regards,
 Paul                          mailto:pmiscml_at_gmail.com