Re: Re: [Kernel-bugs] h5400 patch - merge h5400_bt.c back to h5400.c

Hi Erik !
I plan to submit patches - including removal of IPAQ_H5400_BT - once I
know it got accepted. Or I can submit another patch - including
previous changes - taking care of other things in the kernel. I just
wanted to know if it is ok. Personally, I believe h5400.c and h5400.h
need some cleaning (some left overs from previous changes - ie. my
patch takes care only of BT, but does not clean the BT functions,
assuming that working state is good enough state), but I don't feel
strong enough to find the things to throw away (I bet there are some
in these files!).
Another thing - I think before accepting this patch it would be nice
to resolve the led problem, but I am not too familiar with led
triggers...

I am going to take care of the problem in complex way - fix the
kernel, notify bugzilla, and fix the problem in oe. Other planed
patches are :
defconfigman - the kernel configuration
blueprobe in oe.dev - patch for ttyS1 instead of ttyS3

Cheers
Michal Panczyk

On Thu, Feb 14, 2008 at 9:20 PM, Erik Hovland <erik_at_hovland.org> wrote:
> On Thu, Feb 14, 2008 at 02:08:11AM +0100, Michal Panczyk wrote:
> > I would be grateful for comments, testing and some help with issues I
> > marked.....
>
> I don't see a problem with the patch as far as it basically just moves
> all of the h5400_bt.c work into h5400.c.
>
> It would be nice if the patch also included the removal of the config
> option IPAQ_H5400_BT and the removal of the h5400_bt.c file as well.
>
> Do you plan to submit another patch for that? Or is it not ready for
> removal?
>
> E
>
> --
> Erik Hovland
> mail: erik_at_hovland.org
> web: http://hovland.org/
> PGP/GPG public key available on request
>
> _______________________________________________
> H5400-port mailing list
> H5400-port_at_handhelds.org
> https://www.handhelds.org/mailman/listinfo/h5400-port
Received on Thu Feb 14 2008 - 18:06:14 EST