[PATCH] h5000 fingerprint scanner interface fixes

From: Milan Plzik <milan.plzik_at_gmail.com>
Date: Tue, 14 Aug 2007 22:30:41 +0200

  Hello,

  attached patch fixes h5000 fingerprint scanner. There was one really
important change:

  GPIO 61 on PXA really _DOES_ power up atmel fingerprint scanner.
Without setting this GPIO to 0, only zeroes were read from samcop's FSI.
I also renamed definition of that GPIO in h5400-gpio.h. It was quite
confusing to see that is was renamed to RS232 and took a lot of time to
figure out that the comment was wrong.

  The driver itself is just hotfixed and needs proper cleanup, although
in this state it should be fully functional. There are some places I
don't fully understand yet, and also code, which is not very readable
(most notably buffer management in fsi_drv.c).

  There is also not-very-clean relation between fsi_drv.c and
samcop_fsi.c . fsi_drv.c seems to be sort-of more generic interface, to
which samcop_fsi attaches. But despite of this, it calls functions from
samcop_fsi .

  I'll try to clean it up a bit, but so far I don't have idea where to
begin and how it should be designed. And I don't want to do just partial
cleanups. :)

        Milan

Received on Tue Aug 14 2007 - 16:31:13 EDT

This archive was generated by hypermail 2.2.0 : Tue Aug 14 2007 - 16:32:13 EDT