Re: Re: H5550 Joypad Improvements

On Tue, 2006-02-07 at 18:47 +0000, Erik Hovland wrote:
> Phil Blundell <pb <at> reciva.com> writes:
>
> >
> > On Tue, 2006-02-07 at 00:31 +0000, Erik Hovland wrote:
> > > Anyhow, I am not sure if any patch will get into the 2.4 kernel (but I think
> > > some variation on the patch should get in).
> >
> > That patch looks fine to me. Please check it in to the 2.4 tree. If
> > the adc/touchscreen thing isn't in there already, please check that one
> > in as well.
>
> Both patches have been commited and have been retagged into the hh39 and hh40
> tags. So it should be good to go.

Thanks for comitting the patches.

Your comment about "retagged into hh39 and hh40" scares me, though. Do
you mean that you moved the hh39 and hh40 tags onto the newly-created
versions? If so, this is bad news, since it means that there will be no
way to check out the version that was actually released as hh39. Please
don't ever move existing release tags in this way.

If hh40 is broken in some way that makes it unusable, the right way to
deal with this situation is either to (a) identify the offending patch,
back it out, and release hh41; or (b) cut a new branch based on the hh39
tag, apply the new fixes to that branch as well, and release hh39.1 from
there.

p.
Received on Tue Feb 07 2006 - 15:41:23 EST