Re: [Fwd: Re: [Familiar] iPAQ battery hacking]

On Wed, Jul 13, 2005 at 07:43:10PM +0200, Luca De Cicco wrote:
> On Wed, 2005-07-13 at 11:55 +0100, Philip Blundell wrote:
>
> > At this point, the battery was charging at a high rate, so it clearly
> > wasn't full. But the battery monitor thinks that it has reached its
> > capacity, so it reports the percentage as 100. It's possible that the
> > full level is just calibrated wrongly; try running a learning cycle and
> > see if the situation improves.
> >
> > p.
> >
>
> This is a bug in power managment that i tracked some months i just found
> time to fix it (thanks for pb for the help!).
>
> The attached patch should fix the issue.

The attached patch just adds a 300ms delay. And it does it to a code
branch that is run by all iPAQs not just the h5400 port. So I have a few
questions.

1. Is this specific to h5400s? If so, should the fix be specific too.
   ie. Does it have a negative effect on other ports (like say h3800 or
   h3900)?

2. Is this fixing anything, like is there a spec somewhere that says the
   code should wait 300ms from ac attach to check voltages? If not, it
   would go into the 'working hack' category (which I am not against).

Think you could resubmit the patch without any style changes (extra
lines added and deleted)?

E

-- 
Erik Hovland
mail: erik AT hovland DOT org
web: http://hovland.org/
PGP/GPG public key available on request