On Mon, Mar 28, 2005 at 11:37:26AM -0500, Jamey Hicks wrote:
> The only applications that seem to need modification are dusty old ones
> such as rat and openh323.
I guess the crux here is that RAT is an app that Jim uses Right Now
(tm). So although it may be dusty old, it is useful. If RAT is basically
the must work sort of thing for Jim's project I am inclined to allow
the mono hack into the hh tree (I know you are never going to give me
cvs write access after saying that :). But this is especially true for
the 2.4 tree since there really is no upstream maintainers for the hh tree
anymore. And this patch won't make it into 2.6 since that is all alsa
territory.
> Doesn't alsa provide userspace stereo to mono conversion? If so, adding
> alsa support would solve this problem without making the driver
> unpalatable to the mainstream kernel maintainers.
Alsa does. And we have a working alsa tree again. It may be worth it to
just get alsa working again. Drop Jim's patch and go on from there. But
until someone finds the time to suss-out alsa again Jim's patch is the
shortest path to Jim and others to working with mono 8khz.
And just to provide 0.02USD about the patch, the patch is short and
sweet. I like it. Smart to reuse the double_samples hack. Having said
that I would probably rename double_samples to something like
num_user_channels and initialize it to 2 (since stereo is default) and
change it to one when mono is request. An attempt to do that is attached
as a patch. It is *very* similar to Jim's patch and only makes that
change.
E
-- Erik Hovland mail: erik AT hovland DOT org web: http://hovland.org/ PGP/GPG public key available on request
This archive was generated by hypermail 2.2.0 : Mon Jul 25 2005 - 17:20:11 EDT