Re: [Kernel-discuss] 2.6.11

On Mon, Mar 07, 2005 at 11:07:18PM +0000, Phil Blundell wrote:
> On Mon, 2005-03-07 at 13:32 -0800, Matthew Reimer wrote:
> > +#define SADIV_3_058M 0x0c /* Serial Clock Divider 3.058MHz */
> > +#define SADIV_2_836M 0x0d /* 2.836 MHz */
> > +#define SADIV_1_405M 0x1a /* 1.405 MHz */
> > +#define SADIV_1_026M 0x24 /* 1.026 MHz */
> > +#define SADIV_702K 0x34 /* 702 kHz */
> > +#define SADIV_513K 0x48 /* 513 kHz */
> > +
>
> I think it'd be better to put these defines in pxa-uda1380.c itself, if
> no other driver uses them and it is bad form to do so. Would you like
> to make a patch to do that?

all of the i2s sound chips probably use this (I know ak4535 also does).
So putting something into pxa-i2s.c is probably a good place. The first
attached patch does that (and it does what Nicholas said we should do as
good style and calculates the divisor). Please review.

Second patch fixes up the ak4535 code so it compiles again.

I thought those dma macros were handy. Please consider adding those
back to pxa-regs.h.

E

-- 
Erik Hovland
mail: erik AT hovland DOT org
web: http://hovland.org/
PGP/GPG public key available on request