Re: [Familiar] h55xx headphone jack not usable

I have just received confirmation from Christian (the original poster)
that this patch does the same thing his mask byte change does.

I would appreciate it if you smarter folk (hint: Jamey/Phil) could look
the patch over and possibly include it if it looks good. attached again
to make it easier to find.

Thanks

E

On Tue, Jan 18, 2005 at 02:37:53PM -0800, Erik Hovland wrote:
> On Tue, Jan 18, 2005 at 09:32:17PM +0100, Christian Werner wrote:
> > Phil Blundell wrote:
> > >
> > > On Tue, 2005-01-18 at 21:16 +0100, Christian Werner wrote:
> > > > While trying to get something out of the H55xx headphone
> > > > jack, I found a bug in the initial ak4543 register setup.
> > > > The HPR and HPL bits have to be cleared in order to
> > > > unmute the headphone amplifier (see Output Select table
> > > > on page 32 of the ak4543 manual). Following patch
> > > > remedied the problem
> > >
> > > I think the intention was that the headphone amp should only be powered
> > > up and unmuted when headphones are actually plugged in, rather than left
> > > on all the time.
> >
> > As far as I understand the manual, the headphone amp is powered
> > by the PMHPL and PMHPR bits only. The best way would be to flip
> > HPR/HPL when PMHPL/PMHPR are modified in for I2C_SET_HEADPHONE_SWITCH
> > (page 33 in the manual).
>
> Yeah, I agree.
>
> Does the attached patch do the same thing for you that pre-setting the
> register did? It is an attempt to do what you say is the best way.

-- 
Erik Hovland
mail: erik AT hovland DOT org
web: http://hovland.org/
PGP/GPG public key available on request