Re: [PATCH] some adc_battery improvements

Hello Eugeny,

Friday, March 9, 2007, 1:01:41 AM, you wrote:

> Hello Paul,

> These are patches, those add charging and AC status support.

  Sorry, I yet will need to catch up with your other mails and
patches, but here're quick answers.

> 1)I don't know where APM support code should stay, in h4000 - specific
> drivers or in adc_battery.

  Ideally, this should be separate module which can be attached to any
battery classdev driver. As it's hard to make kernel code perfect from
the first time, adc_battery might be good interim place. We for sure don't
want it in machine specific code.

> 2) Are you going to move battery specific code from h4000.c to something
> like h4000_battery.c ?

  Yes. Now that it's going to contain code, not just data, it's worth
to make own module/driver for it. And generally, we should follow
other ports with this (what doesn't mean that code if final).
hx4700_battery.c is good sample. Either way, I had initial patches
towards that, but I have no idea when I'll be bale to finish/test
that.

-- 
Best regards,
 Paul                            mailto:pmiscml_at_gmail.com