Re: [Hx4700-port] ACX WLAN Working!

Reese, William (Federal PS) wrote:
> Paul said:
>
>
>> 2. If so, why hx4700_acx.c doesn't interract with
>> hx4700_pcmcia.c (or PCMCIA subsyetm in general)? Btw, about
>> hx4700_acx.c - it appears it's machine-specific code for
>> hx4700, shouldn't it live in it's machine dir?
>>
>>
>
> Maybe so. Turning the thing on and off is machine specific; hence the
> dependency
> on a machine specific file. So is turning the LED on and off, which I
> havn't done
> yet. I'd be fine with having hx4700_acx in the machine directory
> and always built then having acx just look for that platform driver.
> Todd, what
> do you think?
>
>
Typically, the hardware-specific drivers reside in the component
directory to which they belong, rather than the machine-specific
directory. That way, if someone makes a change to the component (e.g.
header file), they don't have to go looking around for who might be
using the component. (But the machine owner knows what components are in
his machine.) You'll also notice that hx4700_acx.c includes local files
which would then need to be moved to global include areas. (In
actuality, some of the items currently in the hx4700-specific directory
should be elsewhere).
Received on Thu Jun 01 2006 - 08:25:59 EDT