Re: PATCH: machine_is_h4000 fix, was Re: machne_is_h4000 don't work?!?

Shawn, Eddi,

I'm back from the week-end!
I've just committed your 2 patches.

Thanks!

    :-)

    Michael.

>Hi, Michael,
>
>when you will apply Shawn patch apply this one too.
>
>This should make use of correct machine_is_4000 and should remove
>unnecessary printk.
>
>diff -urN kernel26/arch/arm/common/ipaq/h4000_lcd.c
>kernel26.1/arch/arm/common/ipaq/h4000_lcd.c
>--- kernel26/arch/arm/common/ipaq/h4000_lcd.c 2004-04-11
>11:49:49.581143016 +0200
>+++ kernel26.1/arch/arm/common/ipaq/h4000_lcd.c 2004-04-11
>11:54:36.268559904 +0200
>@@ -165,19 +165,12 @@
> {
> int rc = 0;
>
>- printk("%s: Initializing lcd...\n", __FUNCTION__);
>+ if (! machine_is_h4000 ())
>+ return -ENODEV;
>
>-// next function doesn't work... doesn't identify my h4000 as h4000 :(
>~ eddi
>-// if (! machine_is_h4000 ())
>-// return -ENODEV;
>-
>- printk("%s: Identified device as H4xxx...\n", __FUNCTION__);
>-
>- printk("%s: Registering lcd device...\n", __FUNCTION__);
> rc = lcd_device_register(&h4000_lcd_device);
> if (rc)
> return rc;
>- printk("%s: Registering backlight device...\n", __FUNCTION__);
> rc = backlight_device_register(&h4000_backlight_device);
>
> return rc;
>
>----------------------------------------------------------------------
>
>Joshua, I suggest you to split h1900.c into h1900.c and h1900_lcd.c like
>h4000, so Michael could include H1900 support to his
>zImage/initrd/rootfs
>
>ciao
>
>Eddi
>
>_______________________________________________
>H4100-port mailing list
>H4100-port_at_handhelds.org
>https://www.handhelds.org/mailman/listinfo/h4100-port
>
>
>
>

-- 
Michael Opdenacker
http://opdenacker.org/