Re: Re: Screen calibration & Xfbdev CPU usage

Hello,

In OE tslib is built from cvs HEAD and judging from
http://cvs.handhelds.org/cgi-bin/viewcvs.cgi/apps/tslib/ChangeLog?rev=1.18&content-type=text/vnd.viewcvs-markup
the patch was committed by Michael.
I just noticed OE pulls tslib from the arm-linux repo. I added the (int)
to the line, and I'm rebuilding tslib now.

regards,

Koen

On Tue, 2004-10-19 at 10:58 +0200, Peter Vicman wrote:
> Me again,
>
> I found interesting post in oe mailing list 'Important tslib raw.patch fix -
> http://www.handhelds.org/hypermail/oe/3/0391.html' regards Xfbdev CPU usage.
> It includes patch which fixes this. I don't know how to apply this patch,
> but it only changes comparison (int) (unisigned int) which should be done in
> file 'ts_read_raw_module.c' or 'input-raw.c'.
>
> Can someone try/compile this, because currently I can compile tslib myself?
>
> Regards,
> Peter
>
> ------------------------------------------------------------------
> From: Glenn McGrath <xxx@xxx.xxx>
> Date: Mon May 17 2004 - 00:49:32 EDT
>
> Without this patch Xfbdev cpu usage was increasing to use as much cpu as
> it can get after the first touch, and somehow this patch also fixes
> keyboard issues ive been having, where key presses wouldnt appear untill
> after i touch the touchscreen.
>
> All from a (int) (unisigned int) comparison.....
>
>
> text/plain attachment: tslib_raw_cast.patch
>
> --- a/tslib/tslib/raw.patch 30 Mar 2004 01:12:35 -0000 1.1
> +++ b/tslib/tslib/raw.patch 17 May 2004 04:36:39 -0000 1.2
> @@ -642,7 +642,7 @@
> + /* This version uses EV_SYN */
> + while (total < nr) {
> + ret = read(ts->fd, &ev, sizeof(struct input_event));
> -+ if (ret < sizeof(struct input_event)) {
> ++ if (ret < (int) sizeof(struct input_event)) {
> + total = -1;
> + break;
> + }
> @@ -688,7 +688,7 @@
> +
> + while (total < nr) {
> + ret = read(ts->fd, &ev, sizeof(struct input_event));
> -+ if (ret < sizeof(struct input_event)) break;
> ++ if (ret < (int) sizeof(struct input_event)) break;
> +
> + /*
> + * We must filter events here. We need to look for
>
> _______________________________________________
> H2200-port mailing list
> H2200-port@handhelds.org
> https://handhelds.org/mailman/listinfo/h2200-port
>
Received on Tue Oct 19 05:20:10 2004