Hi Giorgio,
Great and very impression work! Thanks a lot!
:-)
By the way, I think here's the thread Andrew mentioned:
http://lists.arm.linux.org.uk/pipermail/linux-arm/2004-April/007530.html
>
> If it wouldn't break any other platforms, I'd say commit it, and then
> we can figure out how to abstract the GPIO stuff so that h1900/4100
> can use it too.
Right! However, I could be easier if you keep H3900 ASIC3 GPIO stuff
commented out (instead of just removing it). What do you think?
You can edit your patch or re-create it to do this...
Continuing on Matt's idea, and reading your code, here are the
functionalities that we need to abstract:
* codec_reset
* codec_on
* speaker_on
* tda_mode
I suggest to create a h2200_sound and h3900_sound drivers which would
implement these functions (easy from your code), and call new code in
the uda1380 driver that would register these functions.
You can find an example in arch/arm/mach-pxa/h2200_ts.c, though they are
probably much better examples elsewhere in the kernel code.
This way, we can get rid of ifdefs and several types of PDAs can use the
same kernel.
Would you have time to implement this, Giorgio?
Thanks again for everything!
:-)
Michael.
-- Michael Opdenacker http://opdenacker.org/Received on Sun Jun 27 12:00:47 2004
This archive was generated by hypermail 2.1.8 : Sun Jun 27 2004 - 12:01:11 EDT