Re: Re: MMC debug/timing issue

Hello,

> Oops! This morning when I got back into the code to do some more
> testing, I noticed this (line 299 of mmc_protocol.c)
>
> if ( (dev->sdrive->flags & MMC_SDFLAG_VOLTAGE ))
> /* DEBUG(0,"error - current driver doesn't do OCR"); */
> DEBUG(0,"==> before sending MMC_APP_CMD ");
> mmc_simple_cmd(dev, MMC_APP_CMD, 0, RESPONSE_R1);
>
> The uncommented DEBUG will now become part of the if statement. When I
> had both DEBUGs commented out, the mmc_simple_cmd call would only have
> executed on that error condition.

Good spot - the same will happen when debug is disabled. This is one of the
reasons I always insist on conditional code being wrapped in { } - it avoids so
many potential problems :-)

> I will now try disabling debugging in the kernel config. and rebuild the
> module with my current version of the sources and see what happens. I
> might also try reverting to the version with all the DEBUGs in, just to
> make sure that really doesn't work with debugging disabled.

Yep, might be worth a quick scan through the mmc code and also the asic end of
it under arch/arm/mach-sa1100 as well to see if there are any other examples of
this.

TTFN,
John...

=====
Rate Corporate America at http://exec-ratings.bluedonkey.org

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com
Received on Wed Aug 13 2003 - 04:22:12 EDT