Re: Re: Detect LCD of Aximx50 and Aximx50(v) series

Hello Patrick,

Saturday, July 7, 2007, 4:23:29 PM, you wrote:

> On Friday, 6. July 2007 20:09:00 Paul Sokolovsky wrote:
>> Hello Patrick,
>>
>> Friday, July 6, 2007, 8:46:03 PM, you wrote:
>> > Now i have but the LCD Stuff from aximx50.c to a separate aximx50_lcd.c.
>> > We only have to find a display detection method now.
>> >
>> > defconfigman file and kernel sources patch is included.
>>
>> Why to separate lcd code to own file? We're really on "unite" phase
>> now, with the ultimate aim for as much specific machine's code as
>> possible be in one file. The reason is simple: that's how mainline
>> machines are done, and we'd have troubles spooling 100 files into it
>> instead of 30. So, all currently separate modules are in queue to be
>> merged to main machines definition, so it would be unwise for aximx50
>> to go the opposite direction without real need.

> So can you please tell me a device which already uses this method.

  Sure, it's aximx50 ;-).

> so i can
> take a look at the sources. i found much external *_lcd.c files (hx4700,
> magician) so i decided to also but this out of the main file...

  Please read my original response above starting with words "So, all
currently separate modules..." Or maybe I just write it again: it's
true that many current (actually, older) ports have separate *_lcd.c
files. And no, it's not correct. They will be merged back into *.c
eventually.

  So, you patch is well done and good, except that splitting out. Please
just make those changes on aximx50.c directly.

>>
>> > regards,
>> > patrick
>> >
>> > On Friday, 6. July 2007 18:13:40 Patrick Steiner wrote:
>> >> hi,
>> >>
>> >> has anyone a idea how we can detect if its a vga or qvga axim on kernel
>> >> base? perhaps there is any GPIO?
>> >>
>> >> So we can build one Kernel for the device.
>> >> --
>> >> Patrick Steiner | patrick.steiner_at_a1.net
>> >> ICQ: 128261350
>> >> WWW: http://helmsdeep.homelinux.net/~pat
>> >>
>> >> working on (tux4u.skynet):
>> >> Fedora release 7 (Moonshine)
>> >> GNU/Linux 2.6.21-1.3228.fc7

> --
> Patrick Steiner | patrick.steiner_at_a1.net
> ICQ: 128261350
> WWW: http://helmsdeep.homelinux.net/~pat
>
> working on (tux4u.skynet):
> Fedora release 7 (Moonshine)
> GNU/Linux 2.6.21-1.3228.fc7

-- 
Best regards,
 Paul                            mailto:pmiscml_at_gmail.com