[asus-port] Re: [Kernel-discuss] [RFC] PXA27x core voltage change sequencer

From: Anton Vorontsov <cbou_at_mail.ru>
Date: Wed, 6 Dec 2006 21:27:17 +0300

On Wed, Dec 06, 2006 at 04:56:12PM +0100, pHilipp Zabel wrote:
> On 12/6/06, Anton Vorontsov <cbou_at_mail.ru> wrote:
> >Hi all,
> >
> >It seems like we already have 3 devices which have MAX158xx PMICs:
> >a730, hx4700 and some HTC one. I think it's time to unify things.
> >Patch with mach-unspecific driver attached. Tested on hx4700.
>
> Oh joy! :-)
> I'll test it on the magician, which has a MAX1587A. Should it work all the
> same?

MAX1586x-MAX1587x are same from I2C commands point of view. But address
controlled by SRAD pin, which changes address from 0x14 to 0x16 if SRAD
connected to IN instead of GND. This is applies to both 1586 and 1587.
Because of that, I'm thinking about making another Kconfig symbol which
defines MAX1586_SRAD, then _max1586b.c would do "#if MAX1586B_SRAD".

Seems like it's the only way to do it, because otherwise each machine
have to create yet another file with chip definition, platform_device,
and so on... :-/

-- Anton (irc: bd2)
Received on Sat Dec 09 2006 - 02:01:05 EST

This archive was generated by hypermail 2.2.0 : Sat Dec 09 2006 - 02:01:19 EST